fix multi-version ecosystem security vulnerability failure #9434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
approved these changes
Apr 4, 2024
jakecoffman
deleted the
jakecoffman/fix-multiple-version-ecosystem-vulnerability
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For package managers like NPM where a dependency can have multiple versions, we can get a security job that says update a vulnerable dependency but then Dependabot finds the non-vulnerable version and thinks no update is needed.
To fix this I added code at the start of the security update job to search all of the known versions for a vulnerable one so that the update is successful.
To test this I added multi-version functionality to the fake Silent ecosystem.