Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note about assumptions being made #9427

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Add a note about assumptions being made #9427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions updater/lib/dependabot/dependency_group_engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ def self.from_job_config(job:) # rubocop:disable Metrics/PerceivedComplexity
# - We're using the DependencyGroupEngine which means this is a grouped update
# - This is a security update and there are multiple dependencies passed in
# Since there are no groups, the default behavior is to group all dependencies, so create a fake group.
#
# The service doesn't have record of this group, but makes similar assumptions.
# If we change this, we need to update the service to match.
#
# See: https://github.com/dependabot/dependabot-core/issues/9426
job.dependency_groups << {
"name" => job.package_manager,
"rules" => { "patterns" => ["*"] },
Expand Down
Loading