use MSBuild-evaluated property values for TFM #9417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/msbuild-eval-tfm
branch
from
47b5de8
to
6b9bf8e
Compare
JoeRobich
approved these changes
Apr 2, 2024
nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core.Test/Utilities/MSBuildHelperTests.cs
Outdated
Show resolved
Hide resolved
brettfo
force-pushed
the
dev/brettfo/msbuild-eval-tfm
branch
2 times, most recently
from
57dd2cc
to
056716c
Compare
|
Is this change likely to resolve #8578 (comment)? |
No, this change will help ensure we get the proper set of TFMs for a project but will not help cases where PackageReferences are conditionally included. |
JoeRobich
force-pushed
the
dev/brettfo/msbuild-eval-tfm
branch
2 times, most recently
from
750f524
to
646740a
Compare
brettfo
force-pushed
the
dev/brettfo/msbuild-eval-tfm
branch
4 times, most recently
from
48e94ac
to
dd968e9
Compare
JoeRobich
approved these changes
Apr 11, 2024
brettfo
force-pushed
the
dev/brettfo/msbuild-eval-tfm
branch
4 times, most recently
from
08d2d5b
to
012d992
Compare
Release notes: https://github.com/dependabot/dependabot-core/releases/tag/v0.252.0 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
brettfo
force-pushed
the
dev/brettfo/msbuild-eval-tfm
branch
from
012d992
to
4a5af05
Compare
jakecoffman
approved these changes
Apr 12, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd manually parse each build file's XML and extract the
TargetFramework, etc. properties. This could lead to thinking a project supported a TFM when it really didn't. The solution is to use the MSBuild-evaluated value as the project file is loaded.