Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start strict typing gradle #9346

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Start strict typing gradle #9346

merged 3 commits into from
Mar 22, 2024

Conversation

JamieMagee
Copy link
Contributor

No description provided.

@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Mar 21, 2024
@github-actions github-actions bot added the L: java:gradle Maven packages via Gradle label Mar 21, 2024
@JamieMagee JamieMagee force-pushed the jamiemagee/strict-type-gradle branch from 071db9e to ad370dc Compare March 21, 2024 22:36
@JamieMagee JamieMagee marked this pull request as ready for review March 21, 2024 22:36
@JamieMagee JamieMagee requested a review from a team as a code owner March 21, 2024 22:36
@JamieMagee JamieMagee force-pushed the jamiemagee/strict-type-gradle branch from ad370dc to 75e0d44 Compare March 21, 2024 22:44
honeyankit
honeyankit approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@honeyankit honeyankit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JamieMagee JamieMagee force-pushed the jamiemagee/strict-type-gradle branch from 4af1b4d to e490744 Compare March 22, 2024 15:45
@abdulapopoola abdulapopoola merged commit 1b179eb into main Mar 22, 2024
121 checks passed
@abdulapopoola abdulapopoola deleted the jamiemagee/strict-type-gradle branch March 22, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanbrandenburg ryanbrandenburg ryanbrandenburg approved these changes

@honeyankit honeyankit honeyankit approved these changes

Assignees
No one assigned
Labels
L: java:gradle Maven packages via Gradle sorbet 🍦 Relates to Sorbet types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JamieMagee @honeyankit @ryanbrandenburg @abdulapopoola