Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Style/AccessorGrouping to separated #9336

Merged

Conversation

JamieMagee
Copy link
Contributor

While we've been doing the Sorbet migration, we've had to separate out all of our attribute accessors so we can add sigs to them. For example:

class Foo
  attr_reader :bar, :bax, :baz
end

has become

class Foo
  attr_reader :bar
  attr_reader :bax
  attr_reader :baz
end

This change enables the RuboCop Style/AccessorGrouping rule and sets it to separated so we don't have to do this change manually.

Check out the RuboCop documentation for more information.

@JamieMagee JamieMagee requested review from a team as code owners March 20, 2024 20:29
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: ruby:bundler RubyGems via bundler L: elixir:hex Elixir packages via hex L: java:gradle Maven packages via Gradle L: go:modules Golang modules L: elm Elm packages L: terraform Terraform packages L: rust:cargo Rust crates via cargo L: dotnet:nuget NuGet packages via nuget or dotnet L: java:maven Maven packages via Maven L: javascript L: python L: swift Swift packages labels Mar 20, 2024
@JamieMagee JamieMagee force-pushed the jamiemagee/rubocop-style-accessor-grouping-separated branch from 9dcbd27 to 7b8a6ae Compare March 21, 2024 15:18
@JamieMagee JamieMagee force-pushed the jamiemagee/rubocop-style-accessor-grouping-separated branch from 7b8a6ae to 7b83895 Compare March 22, 2024 04:34
@abdulapopoola abdulapopoola merged commit 4a83645 into main Mar 22, 2024
140 checks passed
@abdulapopoola abdulapopoola deleted the jamiemagee/rubocop-style-accessor-grouping-separated branch March 22, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet L: elixir:hex Elixir packages via hex L: elm Elm packages L: go:modules Golang modules L: java:gradle Maven packages via Gradle L: java:maven Maven packages via Maven L: javascript L: php:composer Issues and code for Composer L: python L: ruby:bundler RubyGems via bundler L: rust:cargo Rust crates via cargo L: swift Swift packages L: terraform Terraform packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants