improve nuget v2 handling for non- nuget.org sources #9172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-v2-auth
branch
from
5b97038 to
614399e
Compare
JoeRobich
approved these changes
Feb 29, 2024
bdragon
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing against NuGet v2 APIs revealed that some sources return results in a slightly different shape and follow different mechanisms for providing the
.nupkgdownload URL.This PR does primarily 2 things:
FindPackagesById(), don't rely on the<Id>element under<properties>; it's not always there. Instead rely on the<title>element directly on the<entry>. All tested v2 APIs provided the same value (NuGet. MyGet, Artifactory)..nupkgdownload URL because different sources build it differently. Instead query thePackages(Id=...,Version=...)endpoint and check its<content>element. All tested v2 APIs provided the same value (NuGet, MyGet, Artifactory). The only difference between them was that NuGet and Artifactory had atypeattribute ofapplication/zipand MyGet hadbinary/octet-stream, but the end result was the same.Fixes #9160.