fix(gitlab): pr creator missing default for target_project_id #8985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #8846 |
THETCR
force-pushed
the
fix/gitlab
branch
2 times, most recently
from
e9148e0 to
c85405a
Compare
|
Don't worry about the composer test failures. The PPA we use appears to be down. |
JamieMagee
force-pushed
the
fix/gitlab
branch
from
c85405a to
ea500ad
Compare
|
Can we add a test for this? |
|
@JamieMagee I just rebased and pushed again. Since I figured the PPA would be back online again by now. |
|
Unfortunately I don't have merge rights. Let me ping someone who does. |
jakecoffman
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #8729
target_project_idwasnilwhen it was not provided.Version ^0.240.0 upward is therefore broken for consumers on Gitlab.
This should be the default behaviour again.