fix smoke tests failing because Dir.entries order is not deterministic #8945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulapopoola
approved these changes
Jan 31, 2024
|
It actually fixed the actions smoke test 🙌 |
jakecoffman
deleted the
jakecoffman/ensure-dir-entries-deterministic-order
branch
This was referenced Jan 31, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #8933 I'm noticing some smoke tests are failing to pass and the depednency files are coming back in different order depending on what system is running the test.
I think I tracked it down to
Dir.entrieswhich doesn't guarantee any order, so by sorting we can have more deterministic tests.Most likely this will break some smoke tests and I'll have to regenerate them.