Handle Update PackageReferences more correctly #8827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
reviewed
Jan 17, 2024
nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/MSBuildHelper.cs
Outdated
Show resolved
Hide resolved
brettfo
approved these changes
Jan 17, 2024
JoeRobich
approved these changes
Jan 17, 2024
nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/MSBuildHelper.cs
Outdated
Show resolved
Hide resolved
nuget/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Utilities/MSBuildHelper.cs
Show resolved
Hide resolved
jakecoffman
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code includes all packageReferences the TempProject as
<PackageReference Include, regardless of how they were found in the original context. If (for a given project) a PackageReference exists only as<PackageReference UpdateMSBuild does not load that reference and it should not appear in the Dependencies list. The way I saw this manifesting was that packages which don't get a<PackageReference Includein the csproj were getting manually included due toPR Updates, which causedNU1605errors (package downgrade). I assume it could have other downstream effects that don't occur to me ATM as well.My fix is that we start keeping track of if we have only seen
Updateversions of particularPackageReferenceitems, and if so we should add them to our temp project only asUpdatereferences.