Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle helpers folder into dependabot-nuget gem #8589

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Bundle helpers folder into dependabot-nuget gem #8589

merged 3 commits into from
Jan 16, 2024

Conversation

trejjam
Copy link
Contributor

@trejjam trejjam commented Dec 11, 2023

Fixes #8571

@trejjam trejjam requested a review from a team as a code owner December 11, 2023 12:15
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Dec 11, 2023
@trejjam trejjam force-pushed the feature/nuget-helpers branch from 2e9667a to c227f85 Compare December 14, 2023 20:29
deivid-rodriguez
deivid-rodriguez approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@trejjam trejjam force-pushed the feature/nuget-helpers branch from d8f119e to f0cb991 Compare December 15, 2023 14:14
@trejjam trejjam force-pushed the feature/nuget-helpers branch from f0cb991 to de9e7fa Compare December 29, 2023 13:24
@trejjam
Copy link
Contributor Author

trejjam commented Dec 29, 2023

Hi, since it's approved, is it possible to merge it?

@trejjam trejjam force-pushed the feature/nuget-helpers branch from de9e7fa to 5827b3d Compare January 15, 2024 06:48
@trejjam trejjam requested a review from a team as a code owner January 15, 2024 06:48
@deivid-rodriguez
Copy link
Contributor

So sorry for dropping the ball here, let me merge this!

@deivid-rodriguez
Copy link
Contributor

Actually, needs an approval from @dependabot/azure-dev-ops, should be straightforward though!

@brbayes-msft
Copy link
Contributor

@deivid-rodriguez Approved here. Should be good to merge.

@trejjam trejjam force-pushed the feature/nuget-helpers branch from 5827b3d to d6ac38b Compare January 16, 2024 20:52
@jakecoffman jakecoffman enabled auto-merge (squash) January 16, 2024 21:57
@jakecoffman jakecoffman merged commit fe4e76b into dependabot:main Jan 16, 2024
47 checks passed
@trejjam trejjam deleted the feature/nuget-helpers branch January 17, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brbayes-msft brbayes-msft brbayes-msft approved these changes

@deivid-rodriguez deivid-rodriguez deivid-rodriguez approved these changes

Assignees
No one assigned
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nuget helpers are not part of published gems
4 participants
@trejjam @deivid-rodriguez @brbayes-msft @jakecoffman