clean up smoke.yml #8525
Merged
clean up smoke.yml #8525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honeyankit
approved these changes
Dec 4, 2023
|
Yeah, nice cleanup! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to come up with a way to discover smoke tests dynamically and run them in dependabot-core. While doing that I realized there was a simpler way to do the filters. So I thought I would ship this PR first to clean things up and make sure it worked.
The idea is that if any of the "common" files change we need to run all smoke tests, so there's no reason to list every test out in the filters, just the directories in core that changed. It gets rid of a lot of duplication.