Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for refreshing a grouped security update #8497

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

jakecoffman
Copy link
Member

Forgot to add support for this in #8331

@jakecoffman jakecoffman requested a review from a team as a code owner November 30, 2023 18:18
@jakecoffman
Copy link
Member Author

jakecoffman commented Nov 30, 2023

I just noticed using the CLI it's creating a new PR instead of updating the existing one because the data is coming as existing_pull_requests instead of existing_group_pull_requests. This is because currently for grouped security updates the group is ephemeral.

It's a quick fix in dependency_change to look there instead when it's a group, so I'll do that.

Edit: Wait this will have to be a change in the API, if we use existing_pull_requests then other single PRs will interfere. So this is good to go and I'll fix it in the API.

@honeyankit
Copy link
Contributor

LGTM

@jakecoffman jakecoffman merged commit 9eec592 into main Nov 30, 2023
98 checks passed
@jakecoffman jakecoffman deleted the jakecoffman/refresh-grouped-security-update branch November 30, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants