fix broken updates due to incorrect directory filtering #8405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
approved these changes
Nov 15, 2023
jakecoffman
deleted the
jakecoffman/group-related-directories-together
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8398
In #8331 I introduced filtering files by directory so we could achieve multi-directory updates. This filtering was too naive though as it has broken updates for a few ecosystems that have special handling for directories:
.github/workflowsis automatically used if the directory is/And there may be others!
These special cases resulted in the directory of the file being different than the directory of the update (the job's configured directory).
By marking the files fetched with a
job_directory, we can remove the special cases and the filtering works as expected.