Fix incorrect casing in some Dependabot PR titles #8355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecoffman
approved these changes
Nov 7, 2023
|
Thanks for the swift fix :D |
honeyankit
force-pushed
the
deivid-rodriguez/fix-incorrect-pr-title-case
branch
from
6655d98 to
1a067ab
Compare
When figuring out which case to use, we were looking at previous Dependabot commit messages. However, our regexps were trying to match the whole commit messages, not just the commit title, and that was causing some false positives.
honeyankit
force-pushed
the
deivid-rodriguez/fix-incorrect-pr-title-case
branch
from
1a067ab to
23539f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When figuring out which case to use, we were looking at previous Dependabot commit messages.
However, our regexps were trying to match the whole commit messages, not just the commit title, and that was causing some false positives.