Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of notable things I'd like to highlight about this PR:
initialize
to fixSorbet/KeywordArgumentOrdering
: Optional keyword arguments must be at the end of the parameter listcredentials
andoptions
should becredentials
beingT::Hash[String, String]
options
so it'sT::Hash[String, T.untyped]
overridable
should likely be marked asabstract
, butabstract
methods are required to have no body, and I am not sure if anything is depending on them raising aNotImplementedError
Part of #7782