Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types to clients #8038

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Add types to clients #8038

merged 2 commits into from
Sep 14, 2023

Conversation

JamieMagee
Copy link
Contributor

Mainly adding typed: true to clients, but also includes:

  • Making dependabot.rb and wildcard_matcher.rb typed: strong mostly as a learning experience to see what is required at that type enforcement level
  • Define stubs of to_json for Array and Hash
  • Define stubs for AWS errors which Sorbet is unable to determine (See The TODO RBI file for more details)
  • Wrap *_with_retries clients with T.unsafe as they explicitly rely on method_missing which Sorbet can't deal with

Related to #7782. Supersedes #8028 (as I created that from the main branch of my fork 🤦)

@JamieMagee JamieMagee requested a review from a team as a code owner September 14, 2023 17:11
@JamieMagee JamieMagee mentioned this pull request Sep 14, 2023
Closed
@jakecoffman jakecoffman merged commit 4870e56 into dependabot:main Sep 14, 2023
@JamieMagee JamieMagee deleted the jamiemagee/type-clients branch September 14, 2023 21:03
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecoffman jakecoffman jakecoffman approved these changes

Assignees
No one assigned
Labels
sorbet 🍦 Relates to Sorbet types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieMagee @jakecoffman