Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sig to dependency injection containers #8032

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Add sig to dependency injection containers #8032

merged 4 commits into from
Sep 14, 2023

Conversation

JamieMagee
Copy link
Contributor

Related to #7782

@JamieMagee JamieMagee requested a review from a team as a code owner September 13, 2023 23:25
@Nishnha
Copy link
Member

Nishnha commented Sep 14, 2023

It might be a good idea to create a package_manager enum for type hinting? I don't think we have a canonical list in Dependabot Core outside of

# Ecosystems
require "dependabot/python"
require "dependabot/terraform"
require "dependabot/elm"
require "dependabot/docker"
require "dependabot/git_submodules"
require "dependabot/github_actions"
require "dependabot/composer"
require "dependabot/nuget"
require "dependabot/gradle"
require "dependabot/maven"
require "dependabot/hex"
require "dependabot/cargo"
require "dependabot/go_modules"
require "dependabot/npm_and_yarn"
require "dependabot/bundler"
require "dependabot/pub"
require "dependabot/swift"

Copy link
Member

@jakecoffman jakecoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Nishnha The updater only calls method on the base so I don't think that's necessary?

@JamieMagee
Copy link
Contributor Author

I think a package manager enum is a good idea, but I'm focusing on adding sigs and less on general refactoring

@jakecoffman
Copy link
Member

Starting to deploy this now.

@jakecoffman jakecoffman merged commit 7bb6287 into dependabot:main Sep 14, 2023
@JamieMagee JamieMagee deleted the jamiemagee/common-sigs branch September 14, 2023 20:05
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants