-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sig to dependency injection containers #8032
Add sig to dependency injection containers #8032
Conversation
It might be a good idea to create a package_manager enum for type hinting? I don't think we have a canonical list in Dependabot Core outside of dependabot-core/updater/lib/dependabot/updater.rb Lines 14 to 31 in 1b6f1e4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@Nishnha The updater only calls method on the base so I don't think that's necessary?
I think a package manager enum is a good idea, but I'm focusing on adding |
Starting to deploy this now. |
Related to #7782