Initialize sorbet #8012
Merged
Initialize sorbet #8012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulapopoola
approved these changes
Sep 11, 2023
jakecoffman
approved these changes
Sep 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is step 2 in the adopting sorbet in an existing codebase guide.
Here's the full output:
bundle exec tapioca initFollowed by the initial type check using sorbet:
bundle exec srb tcbundler/spec/dependabot/bundler/file_updater_spec.rb:451: Unable to resolve constant RUBY_VERSIONS https://srb.help/5002 451 | described_class::RubyRequirementSetter::RUBY_VERSIONS + ["99.0.0"] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Did you mean Dependabot::Bundler::FileUpdater::RubyRequirementSetter::RUBY_VERSIONS? Use -a to autocorrect bundler/spec/dependabot/bundler/file_updater_spec.rb:451: Replace with Dependabot::Bundler::FileUpdater::RubyRequirementSetter::RUBY_VERSIONS 451 | described_class::RubyRequirementSetter::RUBY_VERSIONS + ["99.0.0"] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ bundler/lib/dependabot/bundler/file_updater/ruby_requirement_setter.rb:13: Dependabot::Bundler::FileUpdater::RubyRequirementSetter::RUBY_VERSIONS defined here 13 | RUBY_VERSIONS = %w( ^^^^^^^^^^^^^ Did you mean RUBY_VERSIONS? Use -a to autocorrect bundler/spec/dependabot/bundler/file_updater_spec.rb:451: Replace with RUBY_VERSIONS 451 | described_class::RubyRequirementSetter::RUBY_VERSIONS + ["99.0.0"] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ sorbet/rbi/todo.rbi:23: RUBY_VERSIONS defined here 23 |module T.untyped::RUBY_VERSIONS; end ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ common/spec/dependabot/dependency_file_spec.rb:317: Unable to resolve constant BASE64 https://srb.help/5002 317 | content_encoding: described_class::ContentEncoding::BASE64, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Did you mean Dependabot::Clients::GitlabWithRetries::ContentEncoding::BASE64? Use -a to autocorrect common/spec/dependabot/dependency_file_spec.rb:317: Replace with Dependabot::Clients::GitlabWithRetries::ContentEncoding::BASE64 317 | content_encoding: described_class::ContentEncoding::BASE64, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ common/lib/dependabot/clients/gitlab_with_retries.rb:11: Dependabot::Clients::GitlabWithRetries::ContentEncoding::BASE64 defined here 11 | BASE64 = "base64" ^^^^^^ Did you mean Dependabot::DependencyFile::ContentEncoding::BASE64? Use -a to autocorrect common/spec/dependabot/dependency_file_spec.rb:317: Replace with Dependabot::DependencyFile::ContentEncoding::BASE64 317 | content_encoding: described_class::ContentEncoding::BASE64, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ common/lib/dependabot/dependency_file.rb:13: Dependabot::DependencyFile::ContentEncoding::BASE64 defined here 13 | BASE64 = "base64" ^^^^^^ Did you mean BASE64? Use -a to autocorrect common/spec/dependabot/dependency_file_spec.rb:317: Replace with BASE64 317 | content_encoding: described_class::ContentEncoding::BASE64, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ sorbet/rbi/todo.rbi:22: BASE64 defined here 22 |module T.untyped::BASE64; end ^^^^^^^^^^^^^^^^^^^^^^^^ sorbet/rbi/todo.rbi:22: Dynamic constant references are unsupported https://srb.help/4014 22 |module T.untyped::BASE64; end ^^^^^^^^^ sorbet/rbi/todo.rbi:23: Dynamic constant references are unsupported https://srb.help/4014 23 |module T.untyped::RUBY_VERSIONS; end ^^^^^^^^^ updater/lib/dependabot/sentry.rb:6: The super class Raven::Processor of ExceptionSanitizer does not derive from Class https://srb.help/5067 6 |class ExceptionSanitizer < Raven::Processor ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ sorbet/rbi/todo.rbi:9: Raven::Processor defined here 9 |module ::Raven::Processor; end ^^^^^^^^^^^^^^^^^^^^^^^^^ Errors: 5This led me to make 3 changes on top of the default initialization:
Two issues of error 5002
Sorbet doesn't seem to be able to resolve constants on RSpec
described_class, at least out of the box. For now I've hardcoded the specific constants, and will come back to it later.An unresolved reference to
sentry-ravenThe top level
Gemfiledoesn't importupdater, sosentry-ravenisn't installed andtapioca initdoesn't generate types for it. For now, I've addedupdaterto the list of ignored directories, and will circle back to it at a later date.After making the above changes sorbet runs with no errors:
$ srb tc No errors! Great job.