-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sorbet dependencies #8007
Add sorbet dependencies #8007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm not sure what the difference between adding these gems here versus https://github.com/dependabot/dependabot-core/blob/main/common/dependabot-common.gemspec is.
Yeah, I was torn too. But given the VSCode integration gems are installed here, it seemed like the more appropriate place for the Sorbet gems as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well the omnibus
uses the common
gemspec so I guess it doesn't really matter where we install them as long as these tools are accessible from a bin/docker-dev-shell
container
If we will need it to be available when running/testing the individual ecosystem gems it should go in dependabot-common. |
Yes, they'll be needed to power both IDE integrations, as well as in individual ecosystems. I'll move them to common. |
This was for when it was installed into
|
@Nishnha Sorbet is available using $ bundle exec srb
No sorbet/ directory found. Maybe you want to run 'srb init'?
A type checker for Ruby
Usage:
srb Same as "srb t"
srb (init | initialize) Initializes the `sorbet` directory
srb rbi [options] Manage the `sorbet` directory
srb (t | tc | typecheck) [options] Typechecks the code
Options:
-h, --help View help for this subcommand.
--version Show version.
For full help:
https://sorbet.org |
Part of #7782 and step 1 of the adopting Sorbet in an existing codebase guide.
This will be followed with step 2 initializing sorbet