Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable --verbose when running specs #7708

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

deivid-rodriguez
Copy link
Contributor

That prints the actual RSpec command that gets run under the hood. If the current CI flakies are order dependent, it should allow us to reproduce them.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner August 3, 2023 12:52
@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label Aug 3, 2023
@deivid-rodriguez
Copy link
Contributor Author

Ok. So this did not help reproducing exactly but provided some clues. If I run the command now suggested in the error output, everything still passes. BUT, if I run that command, with my internet connection switched off, then the same set of specs fail, just with a different error message. Well, not exactly the same, I believe some more, but all the specs that fail in CI here also fail without an internet connection. I suspect this is some change in rubygems.org.

@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/bundler-enable-verbose branch 3 times, most recently from 6e44874 to 7c05493 Compare August 3, 2023 15:09
@github-actions github-actions bot added the L: swift Swift packages label Aug 3, 2023
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/bundler-enable-verbose branch from 1243942 to 2ee4125 Compare August 3, 2023 16:47
@github-actions github-actions bot removed the L: swift Swift packages label Aug 3, 2023
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/bundler-enable-verbose branch from 1f11807 to ecd2e80 Compare August 3, 2023 18:16
@deivid-rodriguez deivid-rodriguez changed the title Enable --verbose when running bundler specs Enable --verbose when running specs Aug 3, 2023
@github-actions github-actions bot added L: php:composer Issues and code for Composer L: elixir:hex Elixir packages via hex L: go:modules Golang modules L: javascript L: python L: swift Swift packages labels Aug 3, 2023
@deivid-rodriguez
Copy link
Contributor Author

This was not the proper hint, but I think it does not hurt to have it.

Copy link
Member

@Nishnha Nishnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on this so I think it's fine to enable verbose output

That prints the actual RSpec command that gets run under the hood, so
makes it easier to reproduce and debug a failing "slice".
@deivid-rodriguez deivid-rodriguez force-pushed the deivid-rodriguez/bundler-enable-verbose branch from ecd2e80 to c4e5456 Compare August 4, 2023 16:00
@deivid-rodriguez
Copy link
Contributor Author

I think this is not too invasive, and quite helpful for troubleshooting CI, so let's do it. If somebody finds it too much we can switch back!

@deivid-rodriguez deivid-rodriguez enabled auto-merge (squash) August 4, 2023 16:01
@deivid-rodriguez deivid-rodriguez merged commit 0d78061 into main Aug 4, 2023
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/bundler-enable-verbose branch August 4, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: elixir:hex Elixir packages via hex L: go:modules Golang modules L: javascript L: php:composer Issues and code for Composer L: python L: ruby:bundler RubyGems via bundler L: swift Swift packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants