Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GitCommitChecker to check subdependencies too #7464

Merged
merged 5 commits into from
Jul 17, 2023
Merged

Allow GitCommitChecker to check subdependencies too #7464

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1c39b2
Refactor dependency source management
deivid-rodriguez Jun 21, 2023
d64d1d0
Add an update checker spec, when subdependency metadata is present
deivid-rodriguez Jul 17, 2023
e19b4ab
Allow subdependencies to have an associated git source
deivid-rodriguez Jun 29, 2023
1ba1d57
Reuse `Dependency#source_type` in `Cargo::UpdateChecker#path_dependen…
deivid-rodriguez Jun 30, 2023
40b4473
Pass around subdependency metadata
deivid-rodriguez Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Allow subdependencies to have an associated git source 
Since in Swift all dependencies (including subdependencies) are usually
git dependencies, it's convenient to save the git repository URL during
parsing in the dependency, and then be able to use `GitCommitChecker`
from that URL.
  • Loading branch information
@deivid-rodriguez
deivid-rodriguez committed Jul 17, 2023
commit e19b4ab43cd87ce5f7ddc25a489a9f2b1c9e0907
12 changes: 11 additions & 1 deletion common/lib/dependabot/dependency.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ def version_class
end

def source_details(allowed_types: nil)
sources = requirements.map { |requirement| requirement.fetch(:source) }.uniq.compact
sources = all_sources.uniq.compact
sources.select! { |source| allowed_types.include?(source[:type].to_s) } if allowed_types

git = allowed_types == ["git"]
Expand All @@ -231,6 +231,16 @@ def source_type
details[:type] || details.fetch("type")
end

def all_sources
if top_level?
requirements.map { |requirement| requirement.fetch(:source) }
elsif subdependency_metadata
subdependency_metadata.filter_map { |data| data[:source] }
else
[]
end
end

private

def check_values
Expand Down