Upgrade Node.js to active LTS version (18.x)

[christianvuerings]

Changes

Upgrades the Node.js version that dependabot uses to the latest active LTS (Long Term Support) version which is 18.x. https://nodejs.org/en

Why

• Dependabot currently uses a Maintenance LTS version of Node.js instead of a Active LTS version. https://nodejs.dev/en/about/releases/
  
• We run into the following issue since we have engine-strict enabled and want to avoid

Dependabot uses Node.js v16.20.0
 and NPM 8.19.4
. Due to the engine-strict setting, the update will not succeed.

Related issues / threads

• .npmrc with "engine-strict=true" rule throws EBADENGINE error #4072 (comment)
• NPM: handle EBADENGINE better #7194
• https://zenn.dev/risu729/articles/dependabot-engine-strict

[christianvuerings]

See https://nodejs.org/en/download/releases

[jurre]

Thanks, it probably makes sense to use that latest stable version 👍 It looks like you remove the package lock (by accident?), would you mind taking a look at that?

[jurre]

It looks like this is breaking one of our tests, would you mind taking a look at that? 🙇

[andrejleitner]

npm_and_yarn/spec/dependabot/npm_and_yarn/file_updater_spec.rb:2525

- to eq("is-number@jonschlinkert/is-number#semver:^4.0.0")
+ to eq("is-number@github:jonschlinkert/is-number#semver:^4.0.0")

[christianvuerings]

@jurre @andrejleitner I updated the PR - all tests are passing now

[lizthegrey]

This is required to support the latest Yarn versions, which have dropped 16.x support.

[lizthegrey]

Ping @jurre?

[jurre]

Thanks for the headsup, let me roll this out 👍