Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(maven): use groupId and artifactId for the dependency name #7146

Merged
merged 1 commit into from
Jul 20, 2023
Merged

feat(maven): use groupId and artifactId for the dependency name #7146

merged 1 commit into from
Jul 20, 2023

Conversation

yeikel
Copy link
Contributor

@yeikel yeikel commented Apr 22, 2023 •
edited
Loading

Fixes #3845

Depends on https://github.com/dependabot/smoke-tests/pull/59/files

Implemented just like #6526 as suggested

@yeikel yeikel requested a review from a team as a code owner April 22, 2023 01:57
@github-actions github-actions bot added the L: java:maven Maven packages via Maven label Apr 22, 2023
@yeikel yeikel changed the title update feat(maven): use groupId and artifactId to avoid confusions Apr 22, 2023
@yeikel yeikel changed the title feat(maven): use groupId and artifactId to avoid confusions feat(maven): use groupId and artifactId for the dependency name Apr 22, 2023
@yeikel yeikel changed the title feat(maven): use groupId and artifactId for the dependency name feat(maven): use groupId and artifactId for the dependency name Apr 22, 2023
@yeikel yeikel force-pushed the maven/feat-3845 branch 3 times, most recently from 1ff1d35 to 3a5a514 Compare April 22, 2023 20:17
@yeikel yeikel mentioned this pull request Apr 23, 2023
Merged
@yeikel yeikel force-pushed the maven/feat-3845 branch 11 times, most recently from 9872e1d to da1bb36 Compare April 29, 2023 00:38
@yeikel yeikel force-pushed the maven/feat-3845 branch 5 times, most recently from 1384976 to 1e008b7 Compare May 11, 2023 02:11
@yeikel yeikel force-pushed the maven/feat-3845 branch from 1e008b7 to c9ac9d2 Compare May 11, 2023 13:53
deivid-rodriguez
deivid-rodriguez approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deivid-rodriguez
Copy link
Contributor

Turns out some smoke tests need to be updated. They live at https://github.com/dependabot/smoke-tests.

@yeikel
Copy link
Contributor Author

yeikel commented May 12, 2023

Turns out some smoke tests need to be updated. They live at https://github.com/dependabot/smoke-tests.

Yeah, I submitted a pull request for that along with this one dependabot/smoke-tests#59

@yeikel yeikel force-pushed the maven/feat-3845 branch from 0723566 to 9f9cd02 Compare May 12, 2023 02:04
@deivid-rodriguez
Copy link
Contributor

Oh, I missed that. This is ready then! Will try to deploy your PRs today!

@yeikel yeikel force-pushed the maven/feat-3845 branch from 9f9cd02 to d902784 Compare May 16, 2023 18:04
@yeikel yeikel force-pushed the maven/feat-3845 branch from d902784 to 12191c6 Compare June 26, 2023 03:26
@yeikel
Copy link
Contributor Author

yeikel commented Jun 26, 2023

Oh, I missed that. This is ready then! Will try to deploy your PRs today!

Are you still in a code freeze or is this still planned to be released at some point?

Let me know if you have any additional feedback :)

@deivid-rodriguez
Copy link
Contributor

No, we're no longer frozen, thanks for the remainder!

@yeikel yeikel force-pushed the maven/feat-3845 branch from 12191c6 to d19abd7 Compare July 2, 2023 00:30
@jurre jurre force-pushed the maven/feat-3845 branch from d19abd7 to 4d46872 Compare July 20, 2023 13:17
@jurre jurre force-pushed the maven/feat-3845 branch from 4d46872 to fdf8f83 Compare July 20, 2023 16:10
@jurre jurre merged commit 8919de6 into dependabot:main Jul 20, 2023
@jurre
Copy link
Member

jurre commented Jul 20, 2023

Thanks for this @yeikel and apologies for the slow response on our end

@yeikel
Copy link
Contributor Author

yeikel commented Jul 20, 2023

Thanks for this @yeikel and apologies for the slow response on our end

Thank you for merging It and no worries. I understand that there is a lot going on :)

@yeikel yeikel deleted the maven/feat-3845 branch August 8, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deivid-rodriguez deivid-rodriguez deivid-rodriguez approved these changes

@jurre jurre jurre approved these changes

Assignees
No one assigned
Labels
L: java:maven Maven packages via Maven
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider using groupId and artifactId to avoid confusions
3 participants
@yeikel @deivid-rodriguez @jurre