Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label PRs by the top level folder they update #7044

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Label PRs by the top level folder they update #7044

merged 1 commit into from
Apr 13, 2023

Conversation

deivid-rodriguez
Copy link
Contributor

No description provided.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner April 10, 2023 18:01
landongrindheim
landongrindheim approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@landongrindheim landongrindheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a question around how configuration will be honored, but I see no reason to not give this a try 😄

.github/labeler.yml Outdated Show resolved Hide resolved
@deivid-rodriguez deivid-rodriguez marked this pull request as draft April 10, 2023 18:48
@deivid-rodriguez deivid-rodriguez marked this pull request as ready for review April 11, 2023 21:11
@deivid-rodriguez deivid-rodriguez added the EE Engineering Efficiency label Apr 13, 2023
@deivid-rodriguez
Copy link
Contributor Author

Let's try this!

@deivid-rodriguez deivid-rodriguez enabled auto-merge (squash) April 13, 2023 21:08
@deivid-rodriguez deivid-rodriguez merged commit e6853fe into main Apr 13, 2023
@deivid-rodriguez deivid-rodriguez deleted the labeler branch April 13, 2023 21:10
@yeikel
Copy link
Contributor

yeikel commented Apr 14, 2023

It seems to be failing in some scenarios. Example https://github.com/dependabot/dependabot-core/actions/runs/4695403461/jobs/8324540326?pr=7030

@deivid-rodriguez
Copy link
Contributor Author

Ugg, my bad, typo! Thanks for noticing!

@deivid-rodriguez deivid-rodriguez mentioned this pull request Apr 14, 2023
Merged
@yeikel
Copy link
Contributor

yeikel commented Apr 14, 2023

Ugg, my bad, typo! Thanks for noticing!

It's working now :)

https://github.com/dependabot/dependabot-core/actions/runs/4700405646/jobs/8335038927?pr=7030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeikel yeikel yeikel left review comments

@landongrindheim landongrindheim landongrindheim approved these changes

Assignees
No one assigned
Labels
EE Engineering Efficiency
Projects
Dependabot
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deivid-rodriguez @yeikel @landongrindheim