Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCI source annotation to updater core image #6887

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Conversation

mctofu
Copy link
Contributor

@mctofu mctofu commented Mar 21, 2023

This will help Dependabot include relevant change details when it opens PRs against this image. Support was added in #6864.

I'm not sure if we also need to add this label to each ecosystem image. I'll followup with that change if this doesn't have the expected result.

@mctofu mctofu requested a review from a team as a code owner March 21, 2023 19:20
Copy link
Member

@Nishnha Nishnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mctofu
Copy link
Contributor Author

mctofu commented Mar 22, 2023

Confirmed this label is present in the ecosystem images:

% regctl image inspect ghcr.io/dependabot/dependabot-updater-bundler:9b526b7214f5b03a6d9378efb03b1cc55d258762 | jq .config
{
  "User": "dependabot",
  "Env": [
    "PATH=/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin",
    "DEBIAN_FRONTEND=noninteractive",
    "LC_ALL=en_US.UTF-8",
    "LANG=en_US.UTF-8",
    "GIT_LFS_SKIP_SMUDGE=1",
    "DEPENDABOT_HOME=/home/dependabot",
    "DEPENDABOT_NATIVE_HELPERS_PATH=/opt"
  ],
  "Cmd": [
    "bin/run"
  ],
  "WorkingDir": "/home/dependabot/dependabot-updater",
  "Labels": {
    "org.opencontainers.image.ref.name": "ubuntu",
    "org.opencontainers.image.source": "https://github.com/dependabot/dependabot-core",
    "org.opencontainers.image.version": "20.04"
  },
  "ArgsEscaped": true
}

Labels are also inherited from our base ubuntu image. That means if maintainers don't set the source annotation in their own image Dependabot can pick up the change logs from a base image instead which may not be desired behavior.

This will help Dependabot include relevant change details when it opens PRs against this image. Support was added #6864.

I'm not sure if we also need to add this label to each ecosystem image. I'll followup with that change if this doesn't have the expected result.
@mctofu mctofu merged commit 6ca40e9 into main Mar 22, 2023
@mctofu mctofu deleted the mctofu-patch-1 branch March 22, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants