Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump latest version to reflect current release #6796

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Bump latest version to reflect current release #6796

merged 1 commit into from
Mar 6, 2023

Conversation

landongrindheim
Copy link
Member

@landongrindheim landongrindheim commented Mar 6, 2023 •
edited
Loading

This being out of date caused a CI failure in another branch. It'd be great to make this a static target, but I'm not sure what our process is for locking the version down.

@landongrindheim landongrindheim marked this pull request as ready for review March 6, 2023 19:44
@landongrindheim landongrindheim requested a review from a team as a code owner March 6, 2023 19:44
@landongrindheim landongrindheim merged commit a93faa4 into main Mar 6, 2023
@landongrindheim landongrindheim deleted the bump-version-in-spec branch March 6, 2023 19:52
@jeffwidman
Copy link
Member

jeffwidman commented Mar 6, 2023 •
edited
Loading

We've mocked this kind of thing in core unit tests a lot, but IIUC, these updater tests tend to be sanity checks that function more like lightweight integration tests, so maybe better not to mock... in general, this particularly library tends not to change that often, and not a big deal when it does to bump it. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwidman jeffwidman jeffwidman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@landongrindheim @jeffwidman