Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include summary of errors at the end of job output #6761

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Conversation

mctofu
Copy link
Contributor

@mctofu mctofu commented Mar 1, 2023

This should make it a little easier to diagnose failures without needing to also consult the Dependabot error UIs. It's also handy for figuring out which dependencies failed when theres a long list of dependencies to update.

Adds two potential summaries at the end of the job:

For errors that aren't specific to a dependency:

     +--------------------+
     |    Errors          |
     +--------------------+
     | job_repo_not_found |
     +--------------------+

For errors updating a particular dependency:

+-------------------------------------+
|    Dependencies failed to update    |
+---------------------+---------------+
| best_dependency_yay | unknown_error |
+---------------------+---------------+

@mctofu mctofu force-pushed the mctofu/error-summary branch 3 times, most recently from 5516d04 to 5379404 Compare March 2, 2023 05:30
@mctofu mctofu marked this pull request as ready for review March 2, 2023 05:33
@mctofu mctofu requested a review from a team as a code owner March 2, 2023 05:33
Comment on lines +106 to +112
# Example output:
#
# +-------------------------------------+
# | Dependencies failed to update |
# +---------------------+---------------+
# | best_dependency_yay | unknown_error |
# +---------------------+---------------+
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ❤️ these comments!

updater/lib/dependabot/service.rb Outdated Show resolved Hide resolved
expect(service.summary).
to include("unknown_error")
expect(service.summary).
to include("dependabot-cobol")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔎 Are you working on adding a new ecosystem? 😉

expect(service.summary).
to include("unknown_error")
expect(service.summary).
to include("dependabot-fortran")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 ANOTHER?

Copy link
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this is huge, great idea for improving self-service of our code

mctofu and others added 2 commits March 2, 2023 11:12
This should make it a little easier to diagnose failures without
needing to also consult the Dependabot error UIs. It's also handy
for figuring out which dependencies failed when theres a long list of
dependencies to update.
Co-authored-by: Landon Grindheim <landon.grindheim@gmail.com>
@mctofu mctofu force-pushed the mctofu/error-summary branch from f1791ed to b5ea782 Compare March 2, 2023 19:12
@mctofu mctofu merged commit cc207a6 into main Mar 2, 2023
@mctofu mctofu deleted the mctofu/error-summary branch March 2, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants