-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include summary of errors at the end of job output #6761
Conversation
5516d04
to
5379404
Compare
# Example output: | ||
# | ||
# +-------------------------------------+ | ||
# | Dependencies failed to update | | ||
# +---------------------+---------------+ | ||
# | best_dependency_yay | unknown_error | | ||
# +---------------------+---------------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ❤️ these comments!
expect(service.summary). | ||
to include("unknown_error") | ||
expect(service.summary). | ||
to include("dependabot-cobol") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔎 Are you working on adding a new ecosystem? 😉
expect(service.summary). | ||
to include("unknown_error") | ||
expect(service.summary). | ||
to include("dependabot-fortran") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😱 ANOTHER?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 this is huge, great idea for improving self-service of our code
This should make it a little easier to diagnose failures without needing to also consult the Dependabot error UIs. It's also handy for figuring out which dependencies failed when theres a long list of dependencies to update.
Co-authored-by: Landon Grindheim <landon.grindheim@gmail.com>
f1791ed
to
b5ea782
Compare
This should make it a little easier to diagnose failures without needing to also consult the Dependabot error UIs. It's also handy for figuring out which dependencies failed when theres a long list of dependencies to update.
Adds two potential summaries at the end of the job:
For errors that aren't specific to a dependency:
For errors updating a particular dependency: