Pyproject.toml optional-dependencies #5920
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nishnha
force-pushed
the
nishnha/pyproject-optional-deps
branch
from
d0f8d48
to
a633ba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the
parse_pep621_dependenciesfunciton to also parse optional-dependencies.Currently not passing tests - the shape of the result is wrong. It should be a single list with a multiple objects but it's being returned as a list with lists of objects inside of it.
The
DEPENDENCY_TYPESconstant could be moved into the Ruby code so thatdependenciesandoptional-dependenciescan be parsed in different steps and so any additional dependency keys that need to be parsed can be appended.