-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Terraform from 1.0.11 to 1.1.6 #4748
Conversation
This format is expected downstream to suggest remediation options for github.com repos.
The test failure might be related to #4440 It's strange to see the error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left one nit about extracting a constant but feel free to ignore that as you see fit
@@ -149,7 +149,13 @@ def run_terraform_init | |||
output = e.message | |||
|
|||
if output.match?(PRIVATE_MODULE_ERROR) | |||
raise PrivateSourceAuthenticationFailure, output.match(PRIVATE_MODULE_ERROR).named_captures.fetch("repo") | |||
repo = output.match(PRIVATE_MODULE_ERROR).named_captures.fetch("repo") | |||
git_https_prefix = %r{^git::https://} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this could be a constant 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Went ahead and did this. I was debating this since moving the definition up to the top of the file could hurt readability. That does seem to be a more consistent practice in this repo though so I went with it.
This is a minor release from our last version and includes some new features.
https://github.com/hashicorp/terraform/blob/v1.1/CHANGELOG.md#116-february-16-2022
This update triggered a test failure:
I've addressed this by stripping the
git::https://
and.git
fromgit::https://github.com/dependabot-fixtures/private-terraform-module.git
to match the previous behavior. It might be possible to see other prefixes likegit::ssl://
but the handling of this error is only concerned with https access so I'm allowing other prefixes to pass through unchanged.