[CI] Ensure CI builds pick up native helper changes #4618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
approved these changes
Jan 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #4617
We've determined we have a green + green problem in CI where changes are made to native helpers are not fully tested on branches.
It turns out this was a result of my refactor of this file in #4524, where I removed
-t "$CORE_IMAGE:latest"from thedocker buildthat generated the 'branch image'.Without this branch image tagged as
dependabot/dependabot-core:latest, theDockerfile.ciwill pick up the base image pulled in, which is effectivelymain.This results in us running Dependabot Core using the
native helpersinstalled onmainabsent any changes made on branch.