Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Only bundle install for ecosystem under test #3426

Merged
merged 2 commits into from
Apr 1, 2021
Merged

CI: Only bundle install for ecosystem under test #3426

merged 2 commits into from
Apr 1, 2021

Commits on Apr 1, 2021

  1. CI: Only bundle install for ecosystem under test 

    Currently in the CI container we bundle install for _every_ package,
this ends up taking 4 to 5 minutes on every build for every ecosystem.

Since the tests are split up per ecosystem, we only need to install the
gems for the package that is being tested in this matrix step.

This also introduces a `script/ci-test` per ecosystem, it currently runs
both rubocop and rspec for all ecosystems, but the expectation is that
these scripts might diverge per ecosystem.

Running both rspec and rubocop in the same script is done to prevent us
from having to `bundle install` for each of those steps.

We could take this approach a step further and split out a CI container
per ecosystem, and that would let us run rubocop and rspec as separate
steps, but I don't think this is currently worth it.

This should shave about 5 minutes of every matrix build.
    @jurre
    jurre committed Apr 1, 2021
    Configuration menu
    Copy the full SHA
    0877a99 View commit details
    Browse the repository at this point in the history

  2. Update .github/workflows/ci.yml 

    Co-authored-by: Philip Harrison <philip@mailharrison.com>
    @jurre @feelepxyz
    jurre and feelepxyz authored Apr 1, 2021
    Configuration menu
    Copy the full SHA
    e05853d View commit details
    Browse the repository at this point in the history