Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 0.74.0 to ~> 0.75.0 in /common #1417

Merged
merged 2 commits into from
Oct 1, 2019
+3 −1
Merged

Update rubocop requirement from ~> 0.74.0 to ~> 0.75.0 in /common #1417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b251a4f
Update rubocop requirement from ~> 0.74.0 to ~> 0.75.0 in /common
dependabot-preview[bot] Oct 1, 2019
2b0a4d7
Disable cop in method overwrite
greysteil Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/dependabot-common.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "rspec", "~> 3.8"
spec.add_development_dependency "rspec-its", "~> 1.2"
spec.add_development_dependency "rspec_junit_formatter", "~> 0.4"
spec.add_development_dependency "rubocop", "~> 0.74.0"
spec.add_development_dependency "rubocop", "~> 0.75.0"
spec.add_development_dependency "vcr", "~> 5.0"
spec.add_development_dependency "webmock", "~> 3.4"

Expand Down
2 changes: 2 additions & 0 deletions python/lib/dependabot/python/version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ def normalise_prerelease(version)
# rubocop:disable Metrics/LineLength
# rubocop:disable Style/ParallelAssignment
# rubocop:disable Style/RedundantReturn
# rubocop:disable Style/IfUnlessModifier
def old_comp(other)
return unless Gem::Version === other
return 0 if @version == other._version || canonical_segments == other.canonical_segments
Expand Down Expand Up @@ -152,6 +153,7 @@ def old_comp(other)
# rubocop:enable Metrics/LineLength
# rubocop:enable Style/ParallelAssignment
# rubocop:enable Style/RedundantReturn
# rubocop:enable Style/IfUnlessModifier
end
end
end
Expand Down