Add Sorbet type annotations to UpdateChecker, LatestVersionFinder, and VersionResolver for npm_and_yarn
#11903
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR introduces Sorbet type annotations to three core classes in the
npm_and_yarn
ecosystem:UpdateChecker
LatestVersionFinder
RegistryFinder
VersionResolver
What:
The goal is to improve static type safety and developer tooling support for these critical components of the npm/yarn update logic. Types have been added to method signatures, internal state, and helper methods where appropriate.
Why:
Adding Sorbet types to these classes increases confidence when making future changes, helps catch bugs earlier, and makes the code easier to navigate for contributors unfamiliar with the implicit contracts in these classes.
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
srb tc
with no type errors on the updated files.Checklist