go_modules: replace deprecated ioutil library #11541
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Per golang/go#42026, the io/ioutil package has been deprecated since go1.16. Replace them with the standard invocation of os.MkdirTemp https://pkg.go.dev/os#MkdirTemp.
Anything you want to highlight for special attention from reviewers?
a trivial change in the native helper - Go importresolver
in importresolver/main.go:L32-L34, added the removal of the local file on function exit (to prevent "pollution" of the local filesystem) since
TestVCSRemoteForImport
returns only therepo.Remote()
"portion" ofrepo
and the local directory is not used.How will you know you've accomplished your goal?
added a unit test
go_modules/helpers/importresolver/main_test.go
to test the functionVCSRemoteForImport
(to check for syntax errors etc.)Checklist