Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Bitbucket Server file fetcher #1153

Closed
wants to merge 9 commits into from
Closed

[WIP] Bitbucket Server file fetcher #1153

wants to merge 9 commits into from

Conversation

ben-newman-0
Copy link

Initial attempt at adding on-prem Bitbucket Server instances as a file fetcher source (mentioned in the comments of dependabot/feedback#128).

It seems that on-prem Bitbucket Server instances uses a different API to Bitbucket Cloud, so I've created a separate BitbucketServer client for interacting with the API.

Still needs further testing and adding unit tests, but any initial feedback would be welcome 😄

Copy link
Contributor

@greysteil greysteil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I’m away from my computer but will review fully when back. Changes look minimal and sensible though, so I should be able to get this in today / tomorrow.

@chris5287
Copy link
Contributor

@greysteil congrats on the github news today! Just wonder what that means for integrations like this and other ecosystems like Azure DevOps/Gitlab/Bitbucket?

@chris5287
Copy link
Contributor

FYI @kamiizumi see #1211 for reference on how to implement a PullRequestCreator

@ghost
Copy link

ghost commented Jul 12, 2019

Really excited for this feature, any ETA on when it’s going to be finished? 😄

@oeph
Copy link

oeph commented Aug 23, 2019

Are there any news on this?

@ben-newman-0
Copy link
Author

I'm probably not going to be able to look into this anytime soon, as we're moving away from an Atlassian stack to Azure (which Dependabot already has fetchers for). I'm going to close out this PR so it's not left hanging around.

If anyone picks up this feature in the future the following points may be helpful:

  • Bitbucket Cloud and Bitbucket Server (On-Prem) have different APIs, so make sure you're using the correct API (BitBucket Server's API Docs are quite well documented).
  • While I was working on this I checked to see if there were any existing Ruby gems for interacting with BitBucket Server, but I wasn't able to find anything actively maintained. So instead I just directly called Bitbucket's REST API (based on the existing Dependabot client for Bitbucket Cloud).

@greysteil
Copy link
Contributor

@kamiizumi - thanks for your work on this and providing clarity for anyone else who wants to pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants