-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Bitbucket Server file fetcher #1153
[WIP] Bitbucket Server file fetcher #1153
Conversation
# Conflicts: # lib/dependabot/file_fetchers/base.rb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. I’m away from my computer but will review fully when back. Changes look minimal and sensible though, so I should be able to get this in today / tomorrow.
@greysteil congrats on the github news today! Just wonder what that means for integrations like this and other ecosystems like Azure DevOps/Gitlab/Bitbucket? |
FYI @kamiizumi see #1211 for reference on how to implement a PullRequestCreator |
Really excited for this feature, any ETA on when it’s going to be finished? 😄 |
Are there any news on this? |
I'm probably not going to be able to look into this anytime soon, as we're moving away from an Atlassian stack to Azure (which Dependabot already has fetchers for). I'm going to close out this PR so it's not left hanging around. If anyone picks up this feature in the future the following points may be helpful:
|
@kamiizumi - thanks for your work on this and providing clarity for anyone else who wants to pick it up. |
Initial attempt at adding on-prem Bitbucket Server instances as a file fetcher source (mentioned in the comments of dependabot/feedback#128).
It seems that on-prem Bitbucket Server instances uses a different API to Bitbucket Cloud, so I've created a separate BitbucketServer client for interacting with the API.
Still needs further testing and adding unit tests, but any initial feedback would be welcome 😄