split artifacts on OS #10816
Merged
split artifacts on OS #10816
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
approved these changes
Oct 18, 2024
JamieMagee
force-pushed
the
dev/brettfo/nuget-artifacts-directory
branch
from
f86a305
to
7f8881e
Compare
randhircs
force-pushed
the
dev/brettfo/nuget-artifacts-directory
branch
from
7f8881e
to
3ddd15d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updaters build and run in a Linux container, but I, and likely other NuGet developers, use Windows. When investigating issues that only repro in Linux, I'll commonly use a WSL instance and VS Code to do my work, but if I have to switch back and forth between Windows and WSL, it gets painful because I have to regularly clean/rebuild the
artifactsdirectory.By adding the well-known MSBuild value
$(OS)this makes it easier to switch. The value itself isn't interesting, but usually evaluates to eitherWindows_NTorUnix. The end result is that there are separatebin/andobj/directories for each OS so it's possible to run unit tests in both instances in the same codebase at the same time.