Check csproj files for adjacent packages.config. #10803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebasgomez238
changed the title
sebasgomez238
changed the title
|
Add the following to /.bundle/
!.bundle/config
/.env
/tmp
/dependabot-*.gem
Properties/
+bin/
+obj/ |
JamieMagee
reviewed
Oct 17, 2024
JamieMagee
reviewed
Oct 17, 2024
...ory/src/some-project/obj/Debug/net8.0/some-project.GeneratedMSBuildEditorConfig.editorconfig
Outdated
Show resolved
Hide resolved
brettfo
approved these changes
Oct 17, 2024
brettfo
approved these changes
Oct 17, 2024
JamieMagee
approved these changes
Oct 17, 2024
… multiple references
randhircs
force-pushed
the
users/segomez/fix-packages-config-bug
branch
from
52caa95
to
db6a801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the nuget updater was properly running the code to update packages.config files, the
file_fetcher.rbwas only reporting the packages.config in the directory where the job started.This PR adds logic to:
packages.configfiles adjacent to imported project files.fetch_imported_property_filesmethod to improve fetching imported files.The reason for the second change is that when for example
projectA.csprojhas references to bothprojectB.csprojandprojectC.csprojthen the imported project files was incorrectly reporting ONLYprojectC.csproj.All feedback is welcome.