Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove python_new_version feature flag and irrelevant code #10797

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

amazimbe
Copy link
Contributor

@amazimbe amazimbe commented Oct 16, 2024

What are you trying to accomplish?

Remove a feature flag and code that is no longer needed.

The feature flag was added in this PR to ensure the new python version changes could be turned off easily if necessary.

It also removes old code from the previous implementation that is no longer relevant e.g the old version regex.

Anything you want to highlight for special attention from reviewers?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@amazimbe amazimbe requested a review from a team as a code owner October 16, 2024 08:25
@github-actions github-actions bot added L: java:maven Maven packages via Maven L: python labels Oct 16, 2024
@jurre
Copy link
Member

jurre commented Oct 16, 2024

Seems this is removing both the feature flag and (some of) the old version code?

@amazimbe
Copy link
Contributor Author

Seems this is removing both the feature flag and (some of) the old version code?

Yes, it also removes the old versioning code that's no longer applicable in the new version. It replaces the old regex with the new one, for example.

@amazimbe amazimbe changed the title Remove python_new_version feature flag Remove python_new_version feature flag and irrelevant code Oct 16, 2024
@amazimbe amazimbe force-pushed the amazimbe/rm-python_new_version-ff branch from 57aeaad to b1bf69e Compare October 18, 2024 09:05
@amazimbe amazimbe force-pushed the amazimbe/rm-python_new_version-ff branch 2 times, most recently from 1e2a36c to b87fb01 Compare October 23, 2024 09:32
@amazimbe amazimbe force-pushed the amazimbe/rm-python_new_version-ff branch from b87fb01 to 09f4cd4 Compare October 24, 2024 08:15
@amazimbe amazimbe removed the L: java:maven Maven packages via Maven label Oct 24, 2024
@amazimbe amazimbe merged commit 8775e1d into main Oct 24, 2024
58 checks passed
@amazimbe amazimbe deleted the amazimbe/rm-python_new_version-ff branch October 24, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants