Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTelemetry metrics #10691

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Add OpenTelemetry metrics #10691

merged 1 commit into from
Oct 1, 2024

Conversation

JamieMagee
Copy link
Contributor

What are you trying to accomplish?

This adds a dependency on the OpenTelemery metrics gems. It also removes opentelemetry-sdk from common in favour of opentelemetry-api. We only need the concrete implementation in updater.

Anything you want to highlight for special attention from reviewers?

Metrics currently aren't used, but adding this dependency allows us to use them in the future.

How will you know you've accomplished your goal?

Tests pass

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@JamieMagee JamieMagee requested a review from a team as a code owner September 27, 2024 21:36
@JamieMagee JamieMagee force-pushed the jamiemagee/otel-metrics branch from b699b77 to 545e52e Compare September 27, 2024 21:39
@JamieMagee JamieMagee force-pushed the jamiemagee/otel-metrics branch from 545e52e to bcf2e5b Compare September 30, 2024 16:29
@JamieMagee JamieMagee force-pushed the jamiemagee/otel-metrics branch from bcf2e5b to 4ddf355 Compare September 30, 2024 22:10
@thavaahariharangit thavaahariharangit merged commit a732564 into main Oct 1, 2024
123 checks passed
@thavaahariharangit thavaahariharangit deleted the jamiemagee/otel-metrics branch October 1, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants