Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update package to fix bug in XML reader #10687

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Sep 27, 2024

There was a bug in an XML reader used by the NuGet updater that has been fixed in a recent release. Simply bumping that package.

Specifically, the issue was round-tripping attributes with single quotes. E.g., this:

<Element Attribute='value' />

was incorrectly round-tripped as this:

<Element Attribute='value" />

Notice the closing quote of the attribute was changed from a single to a double quote.

@brettfo brettfo requested a review from a team as a code owner September 27, 2024 18:43
@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Sep 27, 2024
@kbukum1 kbukum1 merged commit c95baad into main Sep 27, 2024
87 checks passed
@kbukum1 kbukum1 deleted the dev/brettfo/nuget-xml-reader branch September 27, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants