Strict type go_modules

[JamieMagee]

What are you trying to accomplish?

Complete strict sorbet typing go_modules

Anything you want to highlight for special attention from reviewers?

Also enabled Sorbet/StrictSigil to prevent regressions

How will you know you've accomplished your goal?

Tests pass

Checklist

• I have run the complete test suite to ensure all tests and linters pass.
• I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
• I have written clear and descriptive commit messages.
• I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
• I have ensured that the code is well-documented and easy to understand.

[jeffwidman]

I skimmed this, and it looks fine to me... I didn't take the time to doublecheck every annotation.

Left a question that I trust you probably got it right, and my question is more "help me understand Sorbet in this context"...

[jeffwidman]

Was this a bug discovered through the typing exercise?

[JamieMagee]

So the <=> method comes from kernel.rbi and is defined as

sig do
    params(
        other: BasicObject,
    )
    .returns(T.nilable(Integer))
  end
  def <=>(other); end

Unfortunately, overriding that directly results in 2 errors:

Expected T.nilable(T.any(String, Integer, Gem::Version)) but found BasicObject for argument version7002

and

Method is_a? does not exist on BasicObject (fix available)7003

I think I could force it to use VersionParameter to fix both these, but I am not 100% sure if I can do that. This felt like a compromise.