Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsupported PNPM error message #10094

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Jun 27, 2024

What are you trying to accomplish?

Give good error messages.

Anything you want to highlight for special attention from reviewers?

PNPM 9 is now supported.

How will you know you've accomplished your goal?

New error reads properly.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

PNPM 9 is now supported.
@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner June 27, 2024 11:08
@jurre
Copy link
Member

jurre commented Jun 27, 2024

Hey hey 👋 what kinds of errors are you seeing currently @deivid-rodriguez ?

@deivid-rodriguez
Copy link
Contributor Author

I'm not seeing any errors, I just saw this in the code base and noticed the message needed an update :)

I do suspect there's something not quite working with corepack version switching because I noticed that 176339f was already present before upgrading PNPM at #10073. So my understanding is that corepack should've been switching to PNPM 9 when finding an modern PNPM lockfile and not revert the lockfile format, even without #10073.

So I will dig a bit more into that, in case there's something else that needs fixing!

@kbukum1 kbukum1 self-requested a review July 3, 2024 23:31
@jeffwidman jeffwidman merged commit 2eea6cc into dependabot:main Dec 12, 2024
50 checks passed
@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/fix-pnpm-error-message branch December 12, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants