Update bundler module to ruby 3.3.3 #10038

DuncSmith · 2024-06-19T09:46:28Z

After upgrading our rails app to ruby 3.3.3, we started to get Dependabot::Bundler::FileUpdater::RubyRequirementSetter::RubyVersionNotFound errors

This change updates the ruby requirement to 3.3.3

Trace

updater | 2024/06/18 09:18:49 INFO <job_843844123> Checking if openapi3_parser 0.9.2 needs updating
updater | 2024/06/18 09:18:49 ERROR <job_843844123> Error processing openapi3_parser (Dependabot::Bundler::FileUpdater::RubyRequirementSetter::RubyVersionNotFound)
updater | 2024/06/18 09:18:49 ERROR <job_843844123> Dependabot::Bundler::FileUpdater::RubyRequirementSetter::RubyVersionNotFound
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/bundler/lib/dependabot/bundler/file_updater/ruby_requirement_setter.rb:65:in `ruby_version'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/bundler/lib/dependabot/bundler/file_updater/ruby_requirement_setter.rb:33:in `rewrite'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/bundler/lib/dependabot/bundler/update_checker/file_preparer.rb:262:in `block in lock_ruby_version'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/bundler/lib/dependabot/bundler/update_checker/file_preparer.rb:260:in `each'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/bundler/lib/dependabot/bundler/update_checker/file_preparer.rb:260:in `lock_ruby_version'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/bundler/lib/dependabot/bundler/update_checker/file_preparer.rb:178:in `gemfile_content_for_update_check'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/bundler/lib/dependabot/bundler/update_checker/file_preparer.rb:63:in `prepared_dependency_files'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/bundler/lib/dependabot/bundler/update_checker.rb:388:in `prepared_dependency_files'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/bundler/lib/dependabot/bundler/update_checker.rb:362:in `latest_version_finder'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/bundler/lib/dependabot/bundler/update_checker.rb:203:in `latest_version_details'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/bundler/lib/dependabot/bundler/update_checker.rb:24:in `latest_version'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/refresh_version_update_pull_request.rb:172:in `all_versions_ignored?'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/refresh_version_update_pull_request.rb:83:in `check_and_update_pull_request'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/dependabot-updater/lib/dependabot/updater/operations/refresh_version_update_pull_request.rb:42:in `perform'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/dependabot-updater/lib/dependabot/updater.rb:45:in `run'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/dependabot-updater/lib/dependabot/update_files_command.rb:44:in `block in perform_job'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/dependabot-updater/vendor/ruby/3.3.0/gems/opentelemetry-api-1.2.3/lib/opentelemetry/trace/tracer.rb:37:in `block in in_span'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/dependabot-updater/vendor/ruby/3.3.0/gems/opentelemetry-api-1.2.3/lib/opentelemetry/trace.rb:70:in `block in with_span'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/dependabot-updater/vendor/ruby/3.3.0/gems/opentelemetry-api-1.2.3/lib/opentelemetry/context.rb:87:in `with_value'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/dependabot-updater/vendor/ruby/3.3.0/gems/opentelemetry-api-1.2.3/lib/opentelemetry/trace.rb:70:in `with_span'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/dependabot-updater/vendor/ruby/3.3.0/gems/opentelemetry-api-1.2.3/lib/opentelemetry/trace/tracer.rb:37:in `in_span'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/dependabot-updater/lib/dependabot/update_files_command.rb:18:in `perform_job'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> /home/dependabot/dependabot-updater/lib/dependabot/base_command.rb:37:in `run'
updater | 2024/06/18 09:18:49 ERROR <job_843844123> bin/update_files.rb:46:in `<main>'
updater | 2024/06/18 09:18:49 INFO <job_843844123> Finished job processing
updater | 2024/06/18 09:18:49 INFO Results:
updater | Dependabot encountered '1' error(s) during execution, please check the logs for more details.
updater | +---------------------------------+
updater | |  Dependencies failed to update  |
updater | +-----------------+---------------+
updater | | openapi3_parser | unknown_error |
updater | +-----------------+---------------+

jurre · 2024-06-19T09:58:01Z

I think we'll also want to upgrade the actual version of Ruby that Dependabot uses?

.ruby-version, Dockerfile.updater-core

DuncSmith · 2024-06-20T10:22:14Z

Hi @jurre, I've bumped the ruby version. Successfully rebuilt the updater-core image locally and ran a few specs to confirm it's working. I also built and ran a devcontainer successfully. I'm not sure if any further testing is needed?

bundler/helpers/v2/monkey_patches/definition_ruby_version_patch.rb

bundler/helpers/v1/monkey_patches/definition_ruby_version_patch.rb

deivid-rodriguez

Looks great! ✅

Earlopain · 2024-06-21T10:35:17Z

Ruby 3.3.3 currently suffers from a bug where it causes bundler to remove the dependency of net-protocol for net-pop (a few others as well but this is the most impactful one:

Would this imapct dependabot updates? I can't tell if the tests would cover that case, or if it just irrelevant

deivid-rodriguez · 2024-06-21T10:51:47Z

Great catch! I'm not fully sure if Dependabot would be affected, but it's certainly possible. I guess the issue can be tested through the CLI with a lockfile that includes these gems. The issue can be patched in the Dockerfile by manually fixing the affected gems, but we may also hold the internal Ruby upgrade (Dockerfile.updater-core and .ruby-version) until 3.3.4 is released (a couple months from now).

DuncSmith · 2024-06-24T08:11:40Z

In that case I've reverted this PR to its original purpose, hopefully we at least run dependabot on projects running 3.3.3
TBH I'm not sure the best way to go about patching the Dockerfile to account for the net-protocol issue, open to suggestions/pointers?

Earlopain · 2024-06-24T08:26:02Z

https://bugs.ruby-lang.org/issues/20581#note-2 contains diffs that would need to be applied for this to certainly not be a problem anymore. That would need to be applied to the gemspecs shipped with ruby by default, though I can't tell for certain where they are located.

The best thing would probably to add a test lockfile containing net-pop, maybe this all is a non-issue. I didn't actually test it out, it was just a concern I had. I never contributed here but my personal opinion is to just wait for 3.3.4 unless there's a strong reason to go with 3.3.3 already.

deivid-rodriguez · 2024-06-25T12:15:04Z

In that case I've reverted this PR to its original purpose, hopefully we at least run dependabot on projects running 3.3.3
TBH I'm not sure the best way to go about patching the Dockerfile to account for the net-protocol issue, open to suggestions/pointers?

I agree with @Earlopain that it's easier to wait to 3.3.4, rather than taking the time to verify if the issue affects Dependabot and if it does, to figure out the right files to patch and apply the proper patches directly from the Gemfile.

This PR already allows projects using Ruby 3.3.3 to use Dependabot, so I think it's good to go without blocking on Dependabot upgrading the version it runs itself.

jeffwidman

Thanks @DuncSmith !

And thanks for the review @deivid-rodriguez , I'm basically treating it as the necessary approval here. 😁

only one version per minor release needed and this is provided by the current ruby

This reverts commit 49845fafbd2f5cd280cb107d072a9f6028124b54.

github-actions bot added the L: ruby:bundler RubyGems via bundler label Jun 19, 2024

DuncSmith marked this pull request as ready for review June 19, 2024 09:53

DuncSmith requested a review from a team as a code owner June 19, 2024 09:53

DuncSmith force-pushed the ruby-3.3.3 branch 3 times, most recently from 07f9350 to acc7917 Compare June 20, 2024 10:46

deivid-rodriguez reviewed Jun 20, 2024

View reviewed changes

bundler/helpers/v2/monkey_patches/definition_ruby_version_patch.rb Outdated Show resolved Hide resolved

deivid-rodriguez reviewed Jun 20, 2024

View reviewed changes

bundler/helpers/v1/monkey_patches/definition_ruby_version_patch.rb Outdated Show resolved Hide resolved

DuncSmith force-pushed the ruby-3.3.3 branch 2 times, most recently from 98cb6d7 to ad0edb9 Compare June 20, 2024 11:36

deivid-rodriguez reviewed Jun 20, 2024

View reviewed changes

DuncSmith force-pushed the ruby-3.3.3 branch from ad0edb9 to 54ac6b9 Compare June 24, 2024 07:59

jeffwidman approved these changes Jun 25, 2024

View reviewed changes

DuncSmith added 5 commits June 25, 2024 14:04

Update bundler module to ruby 3.3.3

b434ebd

Update Ruby version for Dependabot itself

d6b271b

Update ruby/setup-ruby to support ruby 3.3.3

21d812a

Remove 3.3.2 from monkey patch, not needed

13f6a11

only one version per minor release needed and this is provided by the current ruby

Revert "Update Ruby version for Dependabot itself"

c60f575

This reverts commit 49845fafbd2f5cd280cb107d072a9f6028124b54.

jeffwidman force-pushed the ruby-3.3.3 branch from 54ac6b9 to c60f575 Compare June 25, 2024 21:04

kbukum1 added 2 commits June 26, 2024 13:18

Merge branch 'main' into ruby-3.3.3

70ca9f7

Merge branch 'main' into ruby-3.3.3

233a239

kbukum1 merged commit d80ad22 into dependabot:main Jun 26, 2024
41 checks passed

deivid-rodriguez mentioned this pull request Jul 19, 2024

Upgrade to latest Ruby patchlevels #10250

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update bundler module to ruby 3.3.3 #10038

Update bundler module to ruby 3.3.3 #10038

DuncSmith commented Jun 19, 2024

jurre commented Jun 19, 2024

DuncSmith commented Jun 20, 2024

deivid-rodriguez left a comment

Earlopain commented Jun 21, 2024

deivid-rodriguez commented Jun 21, 2024

DuncSmith commented Jun 24, 2024

Earlopain commented Jun 24, 2024 •

edited

Loading

deivid-rodriguez commented Jun 25, 2024

jeffwidman left a comment •

edited

Loading

Update bundler module to ruby 3.3.3 #10038

Update bundler module to ruby 3.3.3 #10038

Conversation

DuncSmith commented Jun 19, 2024

jurre commented Jun 19, 2024

DuncSmith commented Jun 20, 2024

deivid-rodriguez left a comment

Choose a reason for hiding this comment

Earlopain commented Jun 21, 2024

deivid-rodriguez commented Jun 21, 2024

DuncSmith commented Jun 24, 2024

Earlopain commented Jun 24, 2024 • edited Loading

deivid-rodriguez commented Jun 25, 2024

jeffwidman left a comment • edited Loading

Choose a reason for hiding this comment

Earlopain commented Jun 24, 2024 •

edited

Loading

jeffwidman left a comment •

edited

Loading