Passing the latest allowable version as package constraints #10018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robaiken
approved these changes
Jun 17, 2024
thavaahariharangit
deleted the
harry/passing-latest-allowable-version-as-constraints
branch
1 task
cs278
reviewed
Jun 18, 2024
Comment on lines
+57
to
+63
| $constraint = $versionParser->parseConstraints($latestAllowableVersion); // your version constraint | ||
| $packageLink = new Link($package->getName(), $dependencyName, $constraint); | ||
|
|
||
| $requires = $package->getRequires(); | ||
| $requires[$dependencyName] = $packageLink; | ||
|
|
||
| $package->setRequires($requires); |
There was a problem hiding this comment.
I don't fully understand what is going on here, but it looks like you are overriding the constraint from the composer.json file with $latestAllowableVersion. I don't know what $latestAllowableVersion contains, but at a guess it's the latest version obtained from the registry? Should it not combine that with the existing constraint instead of overriding it? Does this work properly with dev constraints or is this going to introduce a non-dev constraint when updating dev requirements?
I suspect this is probably the cause of #10033
1 task
thavaahariharangit
added a commit
that referenced
this pull request
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Passing the latest allowable version to native helper and using it as a composer require constraints
Anything you want to highlight for special attention from reviewers?
Functionality was tested with smoke test, and the existing unit tests are updated as per the functionality change.
How will you know you've accomplished your goal?
Error reproduced in local
Given the solution and tested via smoke test.
Checklist