Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify why find_proxy() is slow for us and work with upstream Faraday maintainers to fix #6881

Open
1 task done
jeffwidman opened this issue Mar 21, 2023 · 1 comment
Open
1 task done
Labels
core 🍏 Relates to the dependabot-core library itself T: tech-debt ⚙️

Comments

@jeffwidman
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Code improvement description

@jakecoffman discovered that Faraday's find_proxy is slow, so added a bypass to avoid calling it:

However, we later had to modify another call because a library we use also called find_proxy under the covers:

This could happen in the future if we switch to a library that's calling find_proxy. So ideally we debug further to identify why find_proxy is slow and report (and possibly fix) upstream, rather than just working around it.

Filing an issue here so we don't forget about this.

@jeffwidman jeffwidman changed the title Identify why find_proxy() is slow for us Identify why find_proxy() is slow for us and work with upstream Faraday maintainers to fix Mar 21, 2023
@jeffwidman jeffwidman added the core 🍏 Relates to the dependabot-core library itself label Mar 21, 2023
@jeffwidman
Copy link
Member Author

@jakecoffman did some poking at production, and our jobs didn't appear to speed up after this change.

So this slowness was only happening in the smoke test environment, not our production environment... unclear why, probably something is different about the docker environment, and the failure mode of hanging for a while and then continuing makes me think Faraday makes some linux call, and then wait for it to timeout before falling back to another mode so maybe an env var needs setting??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core 🍏 Relates to the dependabot-core library itself T: tech-debt ⚙️
Projects
None yet
Development

No branches or pull requests

1 participant