Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken MSBuild XML from PackageVersion update when Condition is present #3068

Open
kzu opened this issue Feb 2, 2021 · 1 comment
Open

Broken MSBuild XML from PackageVersion update when Condition is present #3068

kzu opened this issue Feb 2, 2021 · 1 comment
Labels
F: dependency-ignores Allow excluding certain versions L: dotnet:nuget NuGet packages via nuget or dotnet T: bug 🐞 Something isn't working

Comments

@kzu
Copy link

kzu commented Feb 2, 2021

See devlooped/avatar#97.

Note how the Condition is truncated at the end of the element, causing the rest of the document to be broken for MSBuild, which causes the build to fail (in this case with unrelated errors related to missing package versions, because the MSBuild file with the actual versions couldn't even be loaded as valid XML).
@kzu kzu added the T: bug 🐞 Something isn't working label Feb 2, 2021
@kzu kzu changed the title Broken Directory.Packages.props XML from PackageVersion update Broken MSBuild XML from PackageVersion update when Condition is present Mar 31, 2021
@kzu
Copy link
Author

kzu commented Mar 31, 2021

Here's another example, involving a regular msbuildproj: devlooped/avatar@55c6ae7

kzu added a commit to devlooped/avatar that referenced this issue Mar 31, 2021
@kzu
Workaround dependabot breaking condition on bumps
f285e55 
See dependabot/dependabot-core#3068
@asciimike asciimike added the L: dotnet:nuget NuGet packages via nuget or dotnet label Mar 31, 2021
@abdulapopoola abdulapopoola added the F: dependency-ignores Allow excluding certain versions label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
F: dependency-ignores Allow excluding certain versions L: dotnet:nuget NuGet packages via nuget or dotnet T: bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kzu @abdulapopoola @asciimike