Skip to content

Commit

Permalink
revert back pnpm test
Browse files Browse the repository at this point in the history
changed private repository into a private one in pnpm specs
  • Loading branch information
kbukum1 committed Oct 14, 2024
1 parent cb066bb commit 9c056ff
Show file tree
Hide file tree
Showing 5 changed files with 54 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,42 @@
end
end

context "with a private git dep we don't have access to" do
let(:dependency_name) { "cross-fetch" }
let(:version) { "4.0.0" }
let(:previous_version) { "3.1.5" }
let(:requirements) do
[{
file: "package.json",
requirement: "^4.0.0",
groups: ["dependencies"],
source: nil
}]
end
let(:previous_requirements) do
[{
file: "package.json",
requirement: "^3.1.5",
groups: ["dependencies"],
source: nil
}]
end

let(:project_name) { "pnpm/github_dependency_private" }

it "raises a helpful error" do
expect { updated_pnpm_lock_content }
.to raise_error(Dependabot::GitDependenciesNotReachable) do |error|
expect(error.dependency_urls)
.to eq(
[
"https://github.com/dsp-testing/pnpm_github_dependency_private"
]
)
end
end
end

context "when there is a private repo returns a 5xx error" do
let(:project_name) { "pnpm/private_repo_with_server_error" }

Expand Down Expand Up @@ -383,7 +419,7 @@
expect(error.dependency_urls)
.to eq(
[
"https://github.com/Zelcord/electron-context-menu"
"https://github.com/dsp-testing/pnpm_github_dependency_private"
]
)
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
"homepage": "https://github.com/Zelcord/Zelcord#readme",
"dependencies": {
"cross-fetch": "^3.1.5",
"electron-context-menu": "github:Zelcord/electron-context-menu"
"pnpm_github_dependency_private": "github:dsp-testing/pnpm_github_dependency_private"
}
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"homepage": "https://github.com/Zelcord/Zelcord#readme",
"dependencies": {
"cross-fetch": "^3.1.5",
"electron-context-menu": "github:Zelcord/electron-context-menu"
"pnpm_github_dependency_private": "github:dsp-testing/pnpm_github_dependency_private"
},
"packageManager": "pnpm@8.15.6"
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 9c056ff

Please sign in to comment.