Correct handling of updater directory in sorbet (#8247)

* Correct handling of `updater` directory in sorbet * `spoom bump --from=false --to=true` * `spoom bump --from=true --to=strict` * `spoom bump --from=strict --to=strong`
dependabot · Oct 23, 2023 · 7de7855 · 7de7855
1 parent 7ceff8e
commit 7de7855
Show file tree

Hide file tree

Showing 47 changed files with 46 additions and 54 deletions.
diff --git a/bundler/lib/dependabot/bundler.rb b/bundler/lib/dependabot/bundler.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/bundler/lib/dependabot/bundler/version.rb b/bundler/lib/dependabot/bundler/version.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 require "dependabot/version"

diff --git a/cargo/lib/dependabot/cargo.rb b/cargo/lib/dependabot/cargo.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/common/lib/dependabot/config.rb b/common/lib/dependabot/config.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 module Dependabot

diff --git a/composer/lib/dependabot/composer.rb b/composer/lib/dependabot/composer.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/docker/lib/dependabot/docker.rb b/docker/lib/dependabot/docker.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/elm/lib/dependabot/elm.rb b/elm/lib/dependabot/elm.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/git_submodules/lib/dependabot/git_submodules.rb b/git_submodules/lib/dependabot/git_submodules.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/git_submodules/lib/dependabot/git_submodules/version.rb b/git_submodules/lib/dependabot/git_submodules/version.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 require "dependabot/version"

diff --git a/github_actions/lib/dependabot/github_actions.rb b/github_actions/lib/dependabot/github_actions.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/go_modules/lib/dependabot/go_modules.rb b/go_modules/lib/dependabot/go_modules.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/gradle/lib/dependabot/gradle.rb b/gradle/lib/dependabot/gradle.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/hex/lib/dependabot/hex.rb b/hex/lib/dependabot/hex.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/maven/lib/dependabot/maven.rb b/maven/lib/dependabot/maven.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/npm_and_yarn/lib/dependabot/npm_and_yarn.rb b/npm_and_yarn/lib/dependabot/npm_and_yarn.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/nuget/lib/dependabot/nuget.rb b/nuget/lib/dependabot/nuget.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/omnibus/lib/dependabot/omnibus.rb b/omnibus/lib/dependabot/omnibus.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 require "dependabot/python"

diff --git a/pub/lib/dependabot/pub.rb b/pub/lib/dependabot/pub.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/python/lib/dependabot/python.rb b/python/lib/dependabot/python.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/python/lib/dependabot/python/requirement_parser.rb b/python/lib/dependabot/python/requirement_parser.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 module Dependabot

diff --git a/sorbet/config b/sorbet/config
@@ -1,10 +1,6 @@
---dir
-.
---dir
-updater
+--dir=.
 --ignore=tmp/
 --ignore=vendor/
---ignore=updater/
 --disable-watchman
 
 # Sorbet doesn't currently support RSpec very well, so we ignore all of our specs.

diff --git a/sorbet/rbi/todo.rbi b/sorbet/rbi/todo.rbi
@@ -13,11 +13,7 @@ module Dependabot::NpmAndYarn::FileFetcher::Pysch::SyntaxError; end
 module Dependabot::NpmAndYarn::FileParser::DependencySet; end
 module Dependabot::Service::Raven; end
 module Dependabot::Service::Terminal::Table; end
-module Dependabot::Updater::ErrorHandler; end
-module Dependabot::Updater::ErrorHandler::RUN_HALTING_ERRORS; end
 module Dependabot::Updater::Operations; end
-module Dependabot::Updater::Operations::RefreshVersionUpdatePullRequest; end
-module Dependabot::Updater::SubprocessFailed; end
 module HTTP::ConnectionError; end
 class HTTP::Client
   def auth(value); end

diff --git a/sorbet/tapioca/require.rb b/sorbet/tapioca/require.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 # Add your extra requires here (`bin/tapioca require` can be used to bootstrap this list)
diff --git a/swift/lib/dependabot/swift.rb b/swift/lib/dependabot/swift.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strong
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/terraform/lib/dependabot/terraform.rb b/terraform/lib/dependabot/terraform.rb
@@ -1,4 +1,4 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
 # These all need to be required so the various classes can be registered in a

diff --git a/updater/lib/dependabot/base_command.rb b/updater/lib/dependabot/base_command.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "raven"

diff --git a/updater/lib/dependabot/dependency_change.rb b/updater/lib/dependabot/dependency_change.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 # This class describes a change to the project's Dependencies which has been

diff --git a/updater/lib/dependabot/dependency_group_engine.rb b/updater/lib/dependabot/dependency_group_engine.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "dependabot/dependency_group"

diff --git a/updater/lib/dependabot/dependency_snapshot.rb b/updater/lib/dependabot/dependency_snapshot.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "base64"

diff --git a/updater/lib/dependabot/environment.rb b/updater/lib/dependabot/environment.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 module Dependabot

diff --git a/updater/lib/dependabot/file_fetcher_command.rb b/updater/lib/dependabot/file_fetcher_command.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "base64"

diff --git a/updater/lib/dependabot/job.rb b/updater/lib/dependabot/job.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "dependabot/config/ignore_condition"

diff --git a/updater/lib/dependabot/logger/formats.rb b/updater/lib/dependabot/logger/formats.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "logger"

diff --git a/updater/lib/dependabot/update_files_command.rb b/updater/lib/dependabot/update_files_command.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "base64"

diff --git a/updater/lib/dependabot/updater.rb b/updater/lib/dependabot/updater.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 # Dependabot components

diff --git a/updater/lib/dependabot/updater/dependency_group_change_batch.rb b/updater/lib/dependabot/updater/dependency_group_change_batch.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 # This class is responsible for aggregating individual DependencyChange objects

diff --git a/updater/lib/dependabot/updater/error_handler.rb b/updater/lib/dependabot/updater/error_handler.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "dependabot/updater/errors"

diff --git a/updater/lib/dependabot/updater/errors.rb b/updater/lib/dependabot/updater/errors.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 module Dependabot

diff --git a/updater/lib/dependabot/updater/operations.rb b/updater/lib/dependabot/updater/operations.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "dependabot/updater/operations/create_group_security_update_pull_request"

diff --git a/updater/lib/dependabot/updater/operations/create_group_security_update_pull_request.rb b/updater/lib/dependabot/updater/operations/create_group_security_update_pull_request.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "dependabot/updater/security_update_helpers"

diff --git a/updater/lib/dependabot/updater/operations/create_group_update_pull_request.rb b/updater/lib/dependabot/updater/operations/create_group_update_pull_request.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "dependabot/updater/group_update_creation"

diff --git a/updater/lib/dependabot/updater/operations/create_security_update_pull_request.rb b/updater/lib/dependabot/updater/operations/create_security_update_pull_request.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "dependabot/updater/security_update_helpers"

diff --git a/updater/lib/dependabot/updater/operations/group_update_all_versions.rb b/updater/lib/dependabot/updater/operations/group_update_all_versions.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "dependabot/updater/operations/create_group_update_pull_request"

diff --git a/updater/lib/dependabot/updater/operations/refresh_group_security_update_pull_request.rb b/updater/lib/dependabot/updater/operations/refresh_group_security_update_pull_request.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "dependabot/updater/security_update_helpers"

diff --git a/updater/lib/dependabot/updater/operations/refresh_group_update_pull_request.rb b/updater/lib/dependabot/updater/operations/refresh_group_update_pull_request.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 require "dependabot/updater/group_update_creation"

diff --git a/updater/lib/dependabot/updater/operations/refresh_version_update_pull_request.rb b/updater/lib/dependabot/updater/operations/refresh_version_update_pull_request.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 # This class implements our strategy for 'refreshing' an existing Pull Request

diff --git a/updater/lib/dependabot/updater/operations/update_all_versions.rb b/updater/lib/dependabot/updater/operations/update_all_versions.rb
@@ -1,4 +1,4 @@
-# typed: false
+# typed: true
 # frozen_string_literal: true
 
 # This class implements our strategy for iterating over all of the dependencies