Skip to content

Commit

Permalink
Differentiate values missing from the lockfile
Browse files Browse the repository at this point in the history
Co-authored-by: Jake Coffman <jake@jakecoffman.com>
  • Loading branch information
landongrindheim and jakecoffman committed Apr 9, 2024
1 parent 00f69a0 commit 65b2953
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion bundler/lib/dependabot/bundler/helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def self.detected_bundler_version(lockfile)
if (matches = lockfile.content.match(BUNDLER_MAJOR_VERSION_REGEX))
matches[:version].to_i.to_s
else
"unknown"
"unspecified"
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions bundler/spec/dependabot/bundler/helper_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ def described_method(lockfile)
expect(described_method(no_lockfile)).to eql("unknown")
end

it "is unknown if there is no bundled with string" do
expect(described_method(lockfile_bundled_with_missing)).to eql("unknown")
it "is unspecified if there is no bundled with string" do
expect(described_method(lockfile_bundled_with_missing)).to eql("unspecified")
end

it "is 1 if it was bundled with a v1.x version" do
Expand Down

0 comments on commit 65b2953

Please sign in to comment.