Skip to content

Commit

Permalink
Add a note about assumptions being made
Browse files Browse the repository at this point in the history
We need this behavior to stay synced with the behavior in the service.
  • Loading branch information
landongrindheim committed Apr 4, 2024
1 parent 005dd73 commit 38ce107
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions updater/lib/dependabot/dependency_group_engine.rb
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ def self.from_job_config(job:) # rubocop:disable Metrics/PerceivedComplexity
# - We're using the DependencyGroupEngine which means this is a grouped update
# - This is a security update and there are multiple dependencies passed in
# Since there are no groups, the default behavior is to group all dependencies, so create a fake group.
#
# The service doesn't have record of this group, but makes similar assumptions.
# If we change this, we need to update the service to match.
#
# See: https://github.com/dependabot/dependabot-core/issues/9426
job.dependency_groups << {
"name" => job.package_manager,
"rules" => { "patterns" => ["*"] },
Expand Down

0 comments on commit 38ce107

Please sign in to comment.